Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.5 various fixes #2633

Merged
merged 8 commits into from Nov 3, 2020
Merged

6.0.5 various fixes #2633

merged 8 commits into from Nov 3, 2020

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Nov 3, 2020

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels changed the title 605 fixes 6.0.5 various fixes Nov 3, 2020
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
package.json Outdated Show resolved Hide resolved
@jamesdaniels
Copy link
Member Author

@jamesdaniels jamesdaniels commented Nov 3, 2020

@alx-andru I was inspired by your work in #2608, thanks! I decided to implement the API as null properties on the .prototype, I generate the properties via ts-transformer-keys at build time. It's a little magic but it seems to work well enough.

jamesdaniels and others added 3 commits Nov 3, 2020
@google-cla

This comment has been hidden.

@google-cla google-cla bot removed the cla: yes label Nov 3, 2020
@googlebot

This comment has been hidden.

@google-cla
Copy link

@google-cla google-cla bot commented Nov 3, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Nov 3, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jamesdaniels jamesdaniels merged commit af238cd into master Nov 3, 2020
3 checks passed
@jamesdaniels jamesdaniels deleted the 605_fixes branch Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants