Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. #23405

Merged
merged 8 commits into from Dec 29, 2020
Merged

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. #23405

merged 8 commits into from Dec 29, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Nov 19, 2020 •
edited by miss-islington

https://bugs.python.org/issue40137

Automerge-Triggered-By: GH:encukou

@shihai1991 shihai1991 requested a review from rhettinger as a code owner Nov 19, 2020
vstinner
vstinner reviewed Nov 19, 2020
View changes
Modules/_pickle.c Outdated Show resolved Hide resolved
tiran
tiran previously requested changes Nov 20, 2020
View changes
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Nov 20, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@shihai1991
Copy link
Member Author

shihai1991 commented Nov 24, 2020

@corona10 Hi, Dong-hee Na. Can you take a look of this PR? Thanks.

@shihai1991 shihai1991 requested review from encukou and vstinner Dec 7, 2020
encukou
encukou reviewed Dec 15, 2020
View changes
Copy link
Member

@encukou encukou left a comment

This can be simplified; we don't need to use the module state as heavily.

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
Modules/_functoolsmodule.c Outdated Show resolved Hide resolved
@encukou encukou dismissed tiran’s stale review Dec 29, 2020

The requested changes were made.

encukou
encukou approved these changes Dec 29, 2020
View changes
Copy link
Member

@encukou encukou left a comment

Looks good! Thank you!

@encukou encukou added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 29, 2020
@miss-islington miss-islington merged commit dd39123 into python:master Dec 29, 2020
3 checks passed
@shihai1991
Copy link
Member Author

shihai1991 commented Dec 29, 2020

Thanks petr for your review and merge.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991 @adorilson
bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec. (…
d26154c 
…pythonGH-23405)
@sobolevn sobolevn mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou

@tiran tiran

@rhettinger rhettinger

@vstinner vstinner

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@shihai1991 @bedevere-bot @vstinner @encukou @tiran @the-knights-who-say-ni @miss-islington