Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AngularFire version 6 #2282

Merged
merged 38 commits into from Jan 30, 2020
Merged

AngularFire version 6 #2282

merged 38 commits into from Jan 30, 2020

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Jan 8, 2020 •
edited

This is the initial PR for AngularFire version 6.

See #2267 for more details.

@jamesdaniels jamesdaniels mentioned this pull request Jan 8, 2020
Closed
@Timebutt Timebutt mentioned this pull request Jan 10, 2020
Closed
@hiepxanh hiepxanh mentioned this pull request Jan 20, 2020
Closed
@jamesdaniels @alan-agius4
@wagnermaciel @Kamshak
Merged master and working on specs (#2298)
91b4e94 
* merged master
* registerVersion is actually on firebase object
* version replacements and getting specs working

Co-authored-by: Alan Agius <alan.agius4@gmail.com>
Co-authored-by: Wagner Maciel <wagnermaciel@google.com>
Co-authored-by: Valentin Funk <funk.valentin@gmail.com>
@googlebot

This comment has been minimized.

Sign in to view
1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Jan 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jamesdaniels
Copy link
Member Author

@jamesdaniels jamesdaniels commented Jan 29, 2020

Cut to NPM as 6.0.0-next.0

@jamesdaniels jamesdaniels changed the title Start of Version 6 AngularFire version 6 Jan 29, 2020
@jamesdaniels jamesdaniels marked this pull request as ready for review Jan 29, 2020
@jamesdaniels
Copy link
Member Author

@jamesdaniels jamesdaniels commented Jan 29, 2020

Have a couple tests that are still timing out, even with the emulator... will fix those and merge this onto master.

@googlebot
Copy link

@googlebot googlebot commented Jan 30, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Jan 30, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jamesdaniels jamesdaniels merged commit 705505a into master Jan 30, 2020
2 checks passed
@jamesdaniels jamesdaniels deleted the version_6_initial branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamesdaniels @googlebot