Skip to content

Conversation

@asottile
Copy link
Contributor

@asottile asottile commented Oct 5, 2020

without this, the docs build fails due to this:

Warning, treated as error:
/tmp/code/Doc/c-api/decimal.rst:19:Error in "code-block" directive:
1 argument(s) required, 0 supplied.

.. code-block::

    #include "pydecimal.h"

    static int decimal_initialized = 0;
    if (!decimal_initialized) {
        if (import_decimal() < 0) {
            return NULL;
        }

        decimal_initialized = 1;
    }

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @asottile and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d5752aa5c91c56910efe226d0a000bb4481e4f87 3.9

@miss-islington
Copy link
Contributor

Sorry, @asottile and @pablogsal, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d5752aa5c91c56910efe226d0a000bb4481e4f87 3.8

@pablogsal
Copy link
Member

@asottile Could you do the backports, please?

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @asottile and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d5752aa5c91c56910efe226d0a000bb4481e4f87 3.9

@pablogsal
Copy link
Member

Actually, nevermind, there is no Doc/c-api/decimal.rst

@asottile asottile deleted the fix_code_block branch October 11, 2020 18:31
@asottile
Copy link
Contributor Author

yep this one is only for 3.10 :) -- sorry I didn't catch this earlier, but the nightly deadsnakes builds have docs disabled because they break so often

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants