CWE-327 BrokenCryptoAlgorithm recommendation to AES instead of Blowfish#4256
Merged
Conversation
felicitymay
previously approved these changes
Sep 14, 2020
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
The change LGTM - this is a good example where it might be good to move the content of the qhelp file into a resuable fragment so that the set of queries stay in step.
tausbn
requested changes
Sep 22, 2020
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
One minor change needed, otherwise this looks good to me. 👍
|
|
||
|
|
||
| cipher = Blowfish.new(SECRET_KEY) | ||
| cipher = AES.new(SECRET_KEY) |
Contributor
There was a problem hiding this comment.
For consistency, you should change Blowfish to AES in the import statement in the first line of this file.
Contributor
There was a problem hiding this comment.
I'm slightly confused. Line one appears unchanged to me? 😕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the BrokenCryptoAlgorithm second example recommendation to AES instead of Blowfish for Python same as:
JS, Java and C++