Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atexitmodule doc #21456

Merged
merged 1 commit into from Jul 26, 2020
Merged

Conversation

linchiwei123
Copy link
Contributor

@linchiwei123 linchiwei123 commented Jul 13, 2020

No description provided.

Copy link
Contributor

@eamanu eamanu left a comment

The currently inline docs looks good. IMHO this PR doesn't give us any
improve.

But, to be according with other inline docs, this PR is good.

@eamanu
Copy link
Contributor

eamanu commented Jul 14, 2020

The NEWS could be skipped.

@linchiwei123
Copy link
Contributor Author

linchiwei123 commented Jul 14, 2020

The currently inline docs looks good. IMHO this PR doesn't give us any
improve.

But, to be according with other inline docs, this PR is good.

Yes, and help(atexit) would look better.

>>> import atexit
>>> help(atexit)

Before:

:Help on built-in module atexit:

NAME
    atexit - allow programmer to define multiple exit functions to be executedupon normal program termination.

DESCRIPTION
    Two public functions, register and unregister, are defined.

After:

:Help on built-in module atexit:

NAME
    atexit

DESCRIPTION
    allow programmer to define multiple exit functions to be executed
    upon normal program termination.

    Two public functions, register and unregister, are defined.

merwok
merwok approved these changes Jul 14, 2020
Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

LGTM. Thanks @linchiwei123 for the patch.

@nanjekyejoannah nanjekyejoannah merged commit 52bf470 into python:master Jul 26, 2020
4 checks passed
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants