Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation of 8-web-components/5-slots-composition/article.md #631

Merged
merged 14 commits into from May 19, 2020

Conversation

Copy link
Contributor

@Baoyuantop Baoyuantop commented Mar 3, 2020

目标章节:8-web-components/5-slots-composition

当前上游最新 commitjavascript-tutorial/en.javascript.info@fcfef6a
本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md javascript-tutorial/en.javascript.info@8d6a718 中文翻译

注意,参考上游 commit 是指你所修改的文件,在英文仓库中同名文件的对应 commit,即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化,并非根据上游英文仓库的修改而提交的更新,则请填无。

Copy link
Member

@leviding leviding left a comment

几个典型格式问题麻烦全文检查修改一下,整体来说很规范,在修改好后,管理员会尽快 Review,谢谢贡献翻译 👍

8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
@leviding
Copy link
Member

@leviding leviding commented Mar 3, 2020

另外,本 PR 的参考上游 commit 信息需要填写一下

@Baoyuantop
Copy link
Contributor Author

@Baoyuantop Baoyuantop commented Mar 3, 2020

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 8, 2020

CLA assistant check
All committers have signed the CLA.

@MartinsYong MartinsYong self-assigned this Mar 19, 2020
Copy link
Member

@MartinsYong MartinsYong left a comment

校对完成~感谢翻译。

8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Baoyuantop
Copy link
Contributor Author

@Baoyuantop Baoyuantop commented Mar 23, 2020

/done

@leviding leviding changed the title 5-slots-composition Add translation of 8-web-components/5-slots-composition/article.md Mar 24, 2020
@leviding
Copy link
Member

@leviding leviding commented Mar 24, 2020

@Baoyuantop 本 PR 出现了 Conflicting files
8-web-components/5-slots-composition/article.md

麻烦看下解决一下

@Baoyuantop
Copy link
Contributor Author

@Baoyuantop Baoyuantop commented Mar 27, 2020

/done

Copy link
Member

@MartinsYong MartinsYong left a comment

辛苦了,还有一些修改~谢谢

8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@leviding
Copy link
Member

@leviding leviding commented Apr 3, 2020

@Baoyuantop 麻烦再修改一下

@leviding leviding removed the needs +1 label Apr 3, 2020
@leviding
Copy link
Member

@leviding leviding commented Apr 13, 2020

@Baoyuantop 麻烦尽快修改一下~

这个 PR 已经很久没有更新了。我就直接更新了,谢谢~
Copy link
Collaborator

@bemself bemself left a comment

感谢,有一点细节上的改动,还请再查看下~

8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
- `node.assignedSlot` -- returns the `<slot>` element that the `node` is assigned to.
- `slot.assignedNodes({flatten: true/false})` -- DOM nodes, assigned to the slot. The `flatten` option is `false` by default. If explicitly set to `true`, then it looks more deeply into the flattened DOM, returning nested slots in case of nested components and the fallback content if no node assigned.
- `slot.assignedElements({flatten: true/false})` -- DOM elements, assigned to the slot (same as above, but only element nodes).
- `node.assignedSlot` -- 返回将节点分配给的 `<slot>` 元素。
Copy link
Collaborator

@bemself bemself May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `node.assignedSlot` -- 返回将节点分配给的 `<slot>` 元素。
- `node.assignedSlot` -- 返回`node`被分配到的`<slot>`元素。

Copy link
Member

@MartinsYong MartinsYong May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码块和文字之间的空格是需要的

8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
8-web-components/5-slots-composition/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MartinsYong and others added 6 commits May 17, 2020
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
@MartinsYong MartinsYong merged commit 51f6c75 into javascript-tutorial:master May 19, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants