Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40465: Deprecate the optional argument to random.shuffle(). #19867

Merged
merged 5 commits into from May 2, 2020
Merged

bpo-40465: Deprecate the optional argument to random.shuffle(). #19867

merged 5 commits into from May 2, 2020

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 2, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue40465
@rhettinger rhettinger requested a review from serhiy-storchaka May 2, 2020
remilapeyre
remilapeyre reviewed May 2, 2020
View changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Hi, I think there is a typo in the warning message.

Lib/random.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed May 2, 2020
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Please add an entry in What's New.

Doc/library/random.rst Outdated
.. deprecated:: 3.9
In the future, the optional argument *random* will be removed.
Copy link
Member

@serhiy-storchaka serhiy-storchaka May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the shuffle() function is deprecated. It should be specified that the argument is deprecated.

You can also use the deprecated-removed directive to specify the version of removing.

Lib/random.py Outdated Show resolved Hide resolved
rhettinger and others added 4 commits May 2, 2020
@rhettinger
Update Lib/random.py
a88e3f5 
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@rhettinger @serhiy-storchaka
Update Lib/random.py
a1f662c 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@rhettinger
Apply deprecated-removed tag
31f457a
@rhettinger
Merge branch 'deprecate_shuffle_param' of github.com:rhettinger/cpyth…
f4a74e1 
…on into deprecate_shuffle_param
@rhettinger rhettinger merged commit 190fac9 into python:master May 2, 2020
9 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 2, 2020

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!

vegerot added a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@rhettinger @vegerot
bpo-40465: Deprecate the optional argument to random.shuffle(). (pyth…
ee34bfb 
…on#19867)
vegerot added a commit to vegerot/cpython that referenced this issue Jun 10, 2020
@rhettinger @vegerot
bpo-40465: Deprecate the optional argument to random.shuffle(). (pyth…
660ca13 
…on#19867)
gmelikov added a commit to gmelikov/cpython that referenced this issue Aug 22, 2020
@rhettinger @gmelikov
bpo-40465: Deprecate the optional argument to random.shuffle(). (pyth…
8de8aa8 
…on#19867)
chrisburr added a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@rhettinger @chrisburr
bpo-40465: Deprecate the optional argument to random.shuffle(). (pyth…
763bd9d 
…on#19867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@remilapeyre remilapeyre

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@rhettinger @bedevere-bot @serhiy-storchaka @remilapeyre @the-knights-who-say-ni