Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't make underscored attributes as enum members #8302
Merged
+51
−13
Conversation
This comment has been minimized.
This comment has been minimized.
|
A bit silly, but the output of this program import enum
class E(enum.Enum):
_ = 1
__ = 2
___ = 3
____ = 4
_____ = 5
__a__ = 6
print([e.value for e in E])is |
This comment has been minimized.
This comment has been minimized.
Good catch, I wouldn't think anyone would write code like this but it is definitely a valid case, thanks! |
|
Looks great! Thanks for also refactoring the code into a new function. It makes the code easier to read and understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TH3CHARLie commentedJan 17, 2020
fixes #5312
From @JelleZijlstra 's description, for underscored attributes, we don't make them as enum members