Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEasier configuration for Basics of Authentication "Good" example #81
Conversation
|
@gjtorikian: Would you mind reviewing this when you have a moment? |
|
The overall changes look good, but my concern is that this sample (along with others in the directory) are actually tied to a document that readers should follow as if they were building out their own app. In theory, the documentation and this repo are meant to be more basic proof of concept for using the API. (I say "in theory" because we've never actually discussed what the relationship between this repo and the Dev site content should be.) I guess my two immediate thoughts are:
|
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on api/ruby/basics-of-authentication/README.md in 38679ad
Jan 4, 2016
|
Leave line note |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
Leave line note |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
Leave line note |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
localhost:4567 |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on 38679ad
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on api/ruby/basics-of-authentication/README.md in 38679ad
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
replied
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on api/ruby/basics-of-authentication/README.md in 38679ad
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on api/ruby/basics-of-authentication/README.md in 38679ad
Jan 4, 2016
|
localhost:4567 |
This comment has been minimized.
This comment has been minimized.
ryuzaki0
commented on api/ruby/basics-of-authentication/README.md in 38679ad
Jan 4, 2016
|
api/ruby/basics-of-authentication/README.md |
jeeva2530 left a comment
|
Pls active my application |
jgkite commentedDec 7, 2015
I ran into a few issues using the Basics of Authentication sample app (
advanced_server.rb):This PR introduces
URL (please check my logic here).
STDINfallbacks for missing configuration. It also elevates the GitHub URL to a configuration option (defaulting tohttps://github.cominstead of hardcoding in various places. The API base URL is set programmatically based on theHappy-path usage:
Non-interactive usage:
Specifying an alternate GitHub URL:
Omitting a required option: