Update vs code defaults #3110
Update vs code defaults #3110
Conversation
Do not force inclusion of user defined preferences. See the now closed issue [#447](toptal/gitignore.io#447).
|
I don't agree with this change, and I'll refer you to this StackOverflow comment from a member of the VSCode team which provides context:
You are welcome to ignore the VSCode directory for specific projects, but I believe the current set of rules make sense as a good default for VSCode users |
|
I'll quote part of the aforementioned comment (my emphasis):
So this only make sense if you want to enforce settings in a team. Which is not something a general .gitignore should enforce. Instead, this should be a conscious decision made by the team. |
|
There's two extra points I want to make while we're in here discussing this:
Another option we've done in the past is to include comments alongside rules to add context about the situations in which you may want to enable or disable a rule. For example: Lines 26 to 28 in 1a417fe We could include a comment like this before the current rules: # by default all files in this directory should be ignored in Git
.vscode/*
# these rules can be shared with collaborators
# delete these lines if you do not wish to share these config files
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json@openMedi does that feel like a decent compromise here? Personally, that list of "these files can be committed" feels important to have around, even if its usage is a bit nuanced in the wild. |
|
Thanks for enganging with this issue. I think it's a nice idea to inform people about what is possible, however I do think that people should comment in (as opposed to out) non-essentials. So, I think this would be better:
|
|
Any update? |
Do not force inclusion of user defined preferences. See the now closed issue #447.
Reasons for making this change:
See the now closed issue #447. User defined (and user specific) settings shouldn't be included in the repo.