Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: (Golang) Remove the non-essentials #3061

Merged
merged 1 commit into from May 19, 2019
Merged

Conversation

@erdaltsksn
Copy link
Contributor

@erdaltsksn erdaltsksn commented May 18, 2019

Reasons for making this change:

We don't have to state that this is for Hugo. It is very clear from filename and generator will add ###Hugo### at the top.

Links to documentation supporting these rule changes:

These changes are style related so I'm not sure I can find any documentation about that. CONTRIBUTING.md file doesn't include any information about styling.

why: Because we don't have to state that this is for Hugo. It is very
     clear.
     The first letter is transformed into uppercase to match other files
     in this repository.
@shiftkey
Copy link
Member

@shiftkey shiftkey commented May 19, 2019

@erdaltsksn thanks!

@shiftkey shiftkey merged commit 310f125 into github:master May 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Ortega-Dan added a commit to Ortega-Dan/gitignore that referenced this pull request Jun 26, 2019
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants