Skip to content

Upgrade official GitHub actions to latest versions#4899

Merged
juergba merged 2 commits intomochajs:masterfrom
ddzz:gha
Jul 19, 2022
Merged

Upgrade official GitHub actions to latest versions#4899
juergba merged 2 commits intomochajs:masterfrom
ddzz:gha

Conversation

@ddzz
Copy link
Copy Markdown
Contributor

@ddzz ddzz commented Jul 5, 2022

Description of the Change

Quick PR to upgrade all the official GitHub actions to their latest versions in order to stay up-to-date.

Alternate Designs

Dependabot could be used to automate this.

Why should this be in core?

N/A

Benefits

This will reinforce CI stability.

Possible Drawbacks

No breaking changes that I'm aware of.

Applicable issues

N/A

Copy link
Copy Markdown
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddzz Thank you for this PR.
I don't understand why you upgrade most of the actions, and leave a few of them fixed on v2.

@ddzz
Copy link
Copy Markdown
Contributor Author

ddzz commented Jul 17, 2022

@ddzz Thank you for this PR. I don't understand why you upgrade most of the actions, and leave a few of them fixed on v2.

@juergba Thanks for reviewing! Looks like I forgot to save all of my changes before committing. The PR has been updated.

@ddzz ddzz requested a review from juergba July 17, 2022 13:52
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.328% when pulling e0e9d82 on ddzz:gha into 023f548 on mochajs:master.

@juergba juergba added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jul 19, 2022
@juergba juergba added this to the next milestone Jul 19, 2022
@juergba juergba added the run-browser-test run browser tests on forked PR if code is safe label Jul 19, 2022
@github-actions github-actions Bot removed the run-browser-test run browser tests on forked PR if code is safe label Jul 19, 2022
Copy link
Copy Markdown
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddzz thank you

@juergba juergba merged commit 84b2f84 into mochajs:master Jul 19, 2022
@ddzz ddzz deleted the gha branch July 20, 2022 15:55
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants