Update VPA defaults to 1.5.1 in the vpa-release-1.5 branch#8592
Conversation
|
/release-note-none |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/test pull-kubernetes-e2e-autoscaling-vpa-full |
|
/lgtm |
|
@adrianmoisey: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ialidzhikov could you /lgtm ? |
| containers: | ||
| - name: admission-controller | ||
| image: registry.k8s.io/autoscaling/vpa-admission-controller:1.5.0 | ||
| image: registry.k8s.io/autoscaling/vpa-admission-controller:1.5.1 |
There was a problem hiding this comment.
Hi Adrian,
I was wondering if bumping the images in the chart should be before we cut the release. When I checked the release-1.4 branch, I saw that we first bumped the version in vertical-pod-autoscaler/common/version.go. Then , I assume after cutting the release, we bumped the image tag in the manifests.
There was a problem hiding this comment.
Oh, that's a great point! Thanks for pointing that out. Let me fix it.
48693cd to
5fa2370
Compare
|
@adrianmoisey: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-kubernetes-e2e-autoscaling-vpa-full |
What type of PR is this?
/kind feature
What this PR does / why we need it:
VPA 1.5.1 release, see #8468.
Does this PR introduce a user-facing change?