Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat(spanner): add support for change streams transaction exclusion option#2049

Merged
gcf-merge-on-green[bot] merged 37 commits into
googleapis:mainfrom
alkatrivedi:change-stream
May 24, 2024
Merged

feat(spanner): add support for change streams transaction exclusion option#2049
gcf-merge-on-green[bot] merged 37 commits into
googleapis:mainfrom
alkatrivedi:change-stream

Conversation

@alkatrivedi
Copy link
Copy Markdown
Contributor

@alkatrivedi alkatrivedi commented May 20, 2024 •
edited
Loading

Add support for excluding transactions from being recorded in the change streams by passing a new boolean option ExcludeTxnFromChangeStreams in the various write APIs:

runTransaction
getTransaction
runPartitionedUpdate
_mutate

Note: Samples will be added later in separate prs.

@alkatrivedi alkatrivedi requested review from a team May 20, 2024 09:09
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 20, 2024 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels May 20, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels May 21, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 21, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
surbhigarg92
surbhigarg92 reviewed May 21, 2024
View reviewed changes
Comment thread src/database.ts Outdated
Comment thread src/database.ts Outdated
Comment thread src/transaction.ts Outdated
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@alkatrivedi alkatrivedi requested a review from olavloite May 23, 2024 05:51
olavloite
olavloite approved these changes May 23, 2024
View reviewed changes
Comment thread src/table.ts Outdated
Comment thread test/spanner.ts Outdated
Comment thread test/spanner.ts Outdated
Comment thread test/spanner.ts Outdated
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 23, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 23, 2024
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 23, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 23, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit d95cab5 into googleapis:main May 24, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2024
@release-please release-please Bot mentioned this pull request May 22, 2024
Merged
@alkatrivedi alkatrivedi deleted the change-stream branch June 21, 2024 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@olavloite olavloite olavloite approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alkatrivedi @olavloite @surbhigarg92 @yoshi-kokoro