Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat!: node 12 deprecation#1774

Merged
feywind merged 3 commits into
googleapis:node-12-eosfrom
feywind:node-12-deprecation
Jul 26, 2023
Merged

feat!: node 12 deprecation#1774
feywind merged 3 commits into
googleapis:node-12-eosfrom
feywind:node-12-deprecation

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented Jul 19, 2023

This is currently just a placeholder PR for efforts to push out a new major that drops Node 12 support and pulls in a couple of minor breaking changes for typings, and a new gax.

@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2023
@feywind feywind requested review from a team July 19, 2023 19:26
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Jul 19, 2023
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@feywind feywind merged commit d63d0ca into googleapis:node-12-eos Jul 26, 2023
@feywind feywind deleted the node-12-deprecation branch July 26, 2023 18:45
@feywind
Copy link
Copy Markdown
Collaborator Author

feywind commented Jul 26, 2023

This is moved into the googleapis repo now, will re-open a new PR.

feywind added a commit that referenced this pull request Aug 2, 2023
* feat!: node 12 eos (#1774) - moving to googleapis

* feat!: bring in typing interface for Subscription events

* feat!: gax 4 updates - some of this will be regen'd, just testing

* fix!(deps): update dependency google-gax to v4 (#1780)

* fix!(deps): update dependency google-auth-library to v9 (#1776)

Co-authored-by: Megan Potter <57276408+feywind@users.noreply.github.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* build: revert incorrect owlbot change

* deps!: update dependencies and kokoro files

* build: samples package.json should use the new major

* fix!: manually update testIam methods.. not sure why these didn't update

* build: make samples always use current version; update to 4.0.0

* build: update check config

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* build: let sample tests drive npm pack

---------

Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant