This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: Query Profiling#1609
Merged
ehsannas merged 42 commits intoMar 26, 2024
Merged
Conversation
tom-andersen
suggested changes
Mar 19, 2024
Contributor
tom-andersen
left a comment
There was a problem hiding this comment.
There are a few points where the observer pattern implementation breaks down in my opinion. Otherwise, looks good!
ehsannas
commented
Mar 21, 2024
tom-andersen
suggested changes
Mar 25, 2024
Contributor
tom-andersen
left a comment
There was a problem hiding this comment.
I will need some more time, but here is a preliminary review.
tom-andersen
approved these changes
Mar 26, 2024
Contributor
tom-andersen
left a comment
There was a problem hiding this comment.
Looks good. Consider anything remaining as nits.
Beyond this PR, this library needs better logging. I would like to see that every usage of SettableApiFuture also include conditional logging if set or setException returns false. These represent unexpected situations that we are simply ignoring right now.
jskeet
added a commit
to jskeet/google-cloud-dotnet
that referenced
this pull request
Jan 10, 2025
DO NOT MERGE This is just to demonstrate initial prototyping. Things that need fixing: - Rename QueryProfileInfo, probably to ExplainResults to match googleapis/java-firestore#1609 - Create new wrapper types for the various outputs (plan summary and explain metrics). - Possibly create a new wrapper type for ExplainOptions, and expose a single new method accepting that instead of two new methods that vary by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.