Skip to content

Commit edf114d

Browse files
yoshi-automationjskeet
authored andcommitted
feat: Tune Secret Manager auto retry parameters
UNKNOWN removed from retryable errors per AIP-194. Added RESOURCE_EXHAUSTED with adjusted parameters for better performance with spikes of AccessSecretVersion requests at or near quota limits. PiperOrigin-RevId: 383886699 Source-Author: Google APIs <noreply@google.com> Source-Date: Fri Jul 9 11:25:36 2021 -0700 Source-Repo: googleapis/googleapis Source-Sha: 1eade8161f2ef102282869bc3eb18841807b2b46 Source-Link: googleapis/googleapis@1eade81
1 parent c13f1e3 commit edf114d

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

apis/Google.Cloud.SecretManager.V1/Google.Cloud.SecretManager.V1/SecretManagerServiceClient.g.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,14 +173,14 @@ private SecretManagerServiceSettings(SecretManagerServiceSettings existing) : ba
173173
/// </summary>
174174
/// <remarks>
175175
/// <list type="bullet">
176-
/// <item><description>Initial retry delay: 1000 milliseconds.</description></item>
177-
/// <item><description>Retry delay multiplier: 1.3</description></item>
176+
/// <item><description>Initial retry delay: 2000 milliseconds.</description></item>
177+
/// <item><description>Retry delay multiplier: 2</description></item>
178178
/// <item><description>Retry maximum delay: 60000 milliseconds.</description></item>
179-
/// <item><description>Maximum attempts: Unlimited</description></item>
179+
/// <item><description>Maximum attempts: 5</description></item>
180180
/// <item><description>Timeout: 60 seconds.</description></item>
181181
/// </list>
182182
/// </remarks>
183-
public gaxgrpc::CallSettings AccessSecretVersionSettings { get; set; } = gaxgrpc::CallSettingsExtensions.WithRetry(gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000))), gaxgrpc::RetrySettings.FromExponentialBackoff(maxAttempts: 2147483647, initialBackoff: sys::TimeSpan.FromMilliseconds(1000), maxBackoff: sys::TimeSpan.FromMilliseconds(60000), backoffMultiplier: 1.3, retryFilter: gaxgrpc::RetrySettings.FilterForStatusCodes(grpccore::StatusCode.Unavailable, grpccore::StatusCode.Unknown)));
183+
public gaxgrpc::CallSettings AccessSecretVersionSettings { get; set; } = gaxgrpc::CallSettingsExtensions.WithRetry(gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000))), gaxgrpc::RetrySettings.FromExponentialBackoff(maxAttempts: 5, initialBackoff: sys::TimeSpan.FromMilliseconds(2000), maxBackoff: sys::TimeSpan.FromMilliseconds(60000), backoffMultiplier: 2, retryFilter: gaxgrpc::RetrySettings.FilterForStatusCodes(grpccore::StatusCode.Unavailable, grpccore::StatusCode.ResourceExhausted)));
184184

185185
/// <summary>
186186
/// <see cref="gaxgrpc::CallSettings"/> for synchronous and asynchronous calls to

apis/Google.Cloud.SecretManager.V1/synth.metadata

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": "googleapis",
66
"remote": "https://github.com/googleapis/googleapis.git",
7-
"sha": "bff807490f09712527b1af607160a4f7ae48702e"
7+
"sha": "1eade8161f2ef102282869bc3eb18841807b2b46"
88
}
99
}
1010
]

0 commit comments

Comments
 (0)