Skip to content

feat: Include universe_domain in credentials#460

Merged
dazuma merged 1 commit into
googleapis:mainfrom
dazuma:pr/universe-domain
Dec 7, 2023
Merged

feat: Include universe_domain in credentials#460
dazuma merged 1 commit into
googleapis:mainfrom
dazuma:pr/universe-domain

Conversation

@dazuma
Copy link
Copy Markdown
Contributor

@dazuma dazuma commented Dec 1, 2023 •
edited
Loading

Implements the auth requirements for Universe Domain support. Specifically:

  • Added a universe_domain attr_accessor to all credentials classes. This was added to the signet monkeypatch for signet-based credentials, to ExternalAccount::BaseCredentials for all the external credential types, and to Googleauth::Credentials as a delegator to the underlying signet client.
  • GCECredentials obtains the universe_domain value by looking up the Metadata value
  • ExternalAccount types populate the value from the input hash
  • JsonKeyReader based credentials (such as ServiceAccount) get the value from the input file.
  • Altered the logic for determining whether to use JWT to ensure that JWT is used on non-Google universes.

@dazuma dazuma force-pushed the pr/universe-domain branch 2 times, most recently from e33c8ad to bb63cef Compare December 2, 2023 23:37
@dazuma dazuma marked this pull request as ready for review December 3, 2023 00:02
@dazuma dazuma requested a review from a team December 3, 2023 00:02
@dazuma dazuma mentioned this pull request Dec 4, 2023
Closed
@dazuma dazuma force-pushed the pr/universe-domain branch from bb63cef to a9fe7c0 Compare December 5, 2023 01:18
@dazuma dazuma merged commit a7ff57b into googleapis:main Dec 7, 2023
@release-please release-please Bot mentioned this pull request Dec 5, 2023
Merged
@dazuma dazuma deleted the pr/universe-domain branch December 12, 2023 16:51
stanhu added a commit to fog/fog-google that referenced this pull request Jan 28, 2026
@stanhu
Replace google_json_root_url with universe_domain
9f21ede 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
@stanhu stanhu mentioned this pull request Jan 28, 2026
Merged
stanhu added a commit to fog/fog-google that referenced this pull request Jan 28, 2026
@stanhu
Replace google_json_root_url with universe_domain
a43e6f8 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 28, 2026
@stanhu
Replace google_json_root_url with universe_domain
6290faa 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 29, 2026
@stanhu
Replace google_json_root_url with universe_domain
f5c6e58 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 29, 2026
@stanhu
Replace google_json_root_url with universe_domain
235e381 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 29, 2026
@stanhu
Replace google_json_root_url with universe_domain
7b2a11b 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 29, 2026
@stanhu
Replace google_json_root_url with universe_domain
f4fc4ba 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
stanhu added a commit to fog/fog-google that referenced this pull request Jan 29, 2026
@stanhu
Replace google_json_root_url with universe_domain
b4ed4fb 
This replaces the parameter introduced in
#650.

universe_domain was introduced in
googleapis/google-api-ruby-client#17131 and
googleapis/google-auth-library-ruby#460.

This is preferable because the Google Client performs some verification
to ensure credentials match the cloud provider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viacheslav-rostovtsev viacheslav-rostovtsev Awaiting requested review from viacheslav-rostovtsev

1 more reviewer

@bajajneha27 bajajneha27 bajajneha27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dazuma @bajajneha27