Simplify/TS Validation Files#265
Merged
Merged
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
lance
reviewed
Jul 23, 2020
Member
lance
left a comment
There was a problem hiding this comment.
Just clarifying... it does not appear that this actually changes the logic - simply that you've combined the is.ts and validation_error.ts into a single file. Correct?
grant
commented
Jul 23, 2020
Member
Author
grant
left a comment
There was a problem hiding this comment.
Correct, no logic/functional changes.
Just the import/exports. I should probably use a better PR title/description.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the validation logic by removing the folder and just keeping the logic in a
validation.tsfile.Mainly reduces code and improves readability while keeping same functionality.