chore(actions): don't auto-close stale issues and pull requests#235
Merged
lance merged 3 commits intoJul 2, 2020
Merged
Conversation
Open issues and pull requests should be closed by a human who has considered the issue/pr and made a choice based on the content of the issue/pr and the state of the repository. What this means in practice is that some issues will stay open for a long time, even if they are stale. They may be open because it really is something that will be considered for future work. Periodic issue triage should be done by the maintainers, and if an issue _should_ be closed - for example, the issue is no longer relevant - then a maintainer can close it. Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
helio-frota
approved these changes
Jul 1, 2020
lholmquist
approved these changes
Jul 2, 2020
Contributor
lholmquist
left a comment
There was a problem hiding this comment.
After the fix that @helio-frota suggested LGTM
Signed-off-by: Lance Ball <lball@redhat.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open issues and pull requests should be closed by a human who has considered
the issue/pr and made a choice based on the content of the issue/pr and the
state of the repository.
What this means in practice is that some issues will stay open for a long
time, even if they are stale. They may be open because it really is something
that will be considered for future work. Periodic issue triage should be
done by the maintainers, and if an issue should be closed - for example,
the issue is no longer relevant - then a maintainer can close it.
Signed-off-by: Lance Ball lball@redhat.com