fix: add correct types to improve usage in TypeScript projects#202
Merged
Conversation
This commit modifies the existing TypeScript files with improved (read: functional) typings for function parameters. This became an issue when trying to use the module in an existing TypeScript module. Tests for the TypeScript files have been moved to a new test folder specifically for testing TypeScript usage via ts-node. Signed-off-by: Lance Ball <lball@redhat.com>
helio-frota
approved these changes
Jun 3, 2020
lholmquist
approved these changes
Jun 4, 2020
Contributor
lholmquist
left a comment
There was a problem hiding this comment.
npm install and npm test work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the existing TypeScript files with improved
(read: functional) typings for function parameters. This became an
issue when trying to use the module in an existing TypeScript module.
Tests for the TypeScript files have been moved to a new test folder
specifically for testing TypeScript usage via ts-node.
Signed-off-by: Lance Ball lball@redhat.com