From ee66a8d1410eae011231cff18cad02be4ae97a1d Mon Sep 17 00:00:00 2001 From: Matias Szylkowski Date: Fri, 3 Dec 2021 12:54:34 -0500 Subject: [PATCH 1/2] [Story performance] Removed spaces in strings --- .../amp-story/1.0/amp-story-embedded-component.js | 7 ------- extensions/amp-story/1.0/page-advancement.js | 11 +++++++---- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/extensions/amp-story/1.0/amp-story-embedded-component.js b/extensions/amp-story/1.0/amp-story-embedded-component.js index 1d812ab6d6dc..f408903da57e 100644 --- a/extensions/amp-story/1.0/amp-story-embedded-component.js +++ b/extensions/amp-story/1.0/amp-story-embedded-component.js @@ -229,13 +229,6 @@ export class AmpStoryEmbeddedComponent { this.setState_(EmbeddedComponentState.HIDDEN, null /** component */); break; case EmbeddedComponentState.FOCUSED: - if (this.state_ !== EmbeddedComponentState.HIDDEN) { - dev().warn( - TAG, - `Invalid component update. Not possible to go from ${this.state_} - to ${component.state}` - ); - } this.setState_(EmbeddedComponentState.FOCUSED, component); break; } diff --git a/extensions/amp-story/1.0/page-advancement.js b/extensions/amp-story/1.0/page-advancement.js index 49241f3677b1..3895a8509fe9 100644 --- a/extensions/amp-story/1.0/page-advancement.js +++ b/extensions/amp-story/1.0/page-advancement.js @@ -1153,10 +1153,13 @@ export class MediaBasedAdvancement extends AdvancementConfig { // amp-video, amp-audio, as well as amp-story-page with a background audio // are eligible for media based auto advance. let element = pageEl.querySelector( - `amp-video[data-id=${escapeCssSelectorIdent(autoAdvanceStr)}], - amp-video#${escapeCssSelectorIdent(autoAdvanceStr)}, - amp-audio[data-id=${escapeCssSelectorIdent(autoAdvanceStr)}], - amp-audio#${escapeCssSelectorIdent(autoAdvanceStr)}` + `amp-video[data-id=${escapeCssSelectorIdent( + autoAdvanceStr + )}], amp-video#${escapeCssSelectorIdent( + autoAdvanceStr + )}, amp-audio[data-id=${escapeCssSelectorIdent( + autoAdvanceStr + )}], amp-audio#${escapeCssSelectorIdent(autoAdvanceStr)}` ); if ( matches( From de6df6d7a99b2ce5594de94ab2a8d3e8ea2e986f Mon Sep 17 00:00:00 2001 From: Matias Szylkowski Date: Fri, 3 Dec 2021 13:00:07 -0500 Subject: [PATCH 2/2] Removed double spacing --- extensions/amp-story/1.0/logging.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/amp-story/1.0/logging.js b/extensions/amp-story/1.0/logging.js index 020903d3bcb9..70975a788d12 100644 --- a/extensions/amp-story/1.0/logging.js +++ b/extensions/amp-story/1.0/logging.js @@ -83,7 +83,7 @@ const LogType = { /** Warnings */ IMAGES_MAX_720P_OR_SRCSET: { message: - 'Images should not be larger than 720p. If you wish to use' + + 'Images should not be larger than 720p. If you wish to use' + ' images that are larger than 720p, you should specify a srcset.', moreInfo: AMPPROJECT_DOCS + '/guides/responsive/art_direction#srcset', selector: 'img:not([srcset])',