Skip to content

🚀 [Story performance] Removed spaces in strings#37109

Merged
mszylkowski merged 2 commits into
ampproject:mainfrom
mszylkowski:removeSpaces
Dec 3, 2021
Merged

🚀 [Story performance] Removed spaces in strings#37109
mszylkowski merged 2 commits into
ampproject:mainfrom
mszylkowski:removeSpaces

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

Some parts of the code used to have extra spaces due to splitting strings into multiple newlines, making the indentation part of the bundle size.

@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot Bot commented Dec 3, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-embedded-component.js
extensions/amp-story/1.0/logging.js
extensions/amp-story/1.0/page-advancement.js

Comment thread extensions/amp-story/1.0/amp-story-embedded-component.js
@mszylkowski mszylkowski self-assigned this Dec 3, 2021
@mszylkowski mszylkowski merged commit e75e123 into ampproject:main Dec 3, 2021
@mszylkowski mszylkowski deleted the removeSpaces branch December 3, 2021 18:55
@gmajoulet
Copy link
Copy Markdown
Contributor

This PR increased the bundle size (+0.15KB), why was this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants