Skip to content

amp-story-desktop-one-panel background-blur Pre draw image to fade in#35175

Merged
processprocess merged 3 commits into
ampproject:mainfrom
processprocess:draw-img
Jul 12, 2021
Merged

amp-story-desktop-one-panel background-blur Pre draw image to fade in#35175
processprocess merged 3 commits into
ampproject:mainfrom
processprocess:draw-img

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

  • Pre draws image to an off-screen canvas, then fades in the composed image.
  • Adjusts animation to match system layer progress bar.
  • Separates draw logic into functions.

This creates a smooth transition:
https://user-images.githubusercontent.com/3860311/125135823-a2de4c00-e0d7-11eb-9130-0af69e84c219.mp4

Without this the image will flash as it's faded in:
https://user-images.githubusercontent.com/3860311/125135854-b12c6800-e0d7-11eb-8852-cae568d03dac.mp4

@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot Bot commented Jul 9, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/background-blur.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants