Skip to content

✨ [Story interactive] Make disclaimer work RTL#35164

Merged
mszylkowski merged 20 commits into
ampproject:mainfrom
mszylkowski:interactive_toggledisclaimer
Jul 19, 2021
Merged

✨ [Story interactive] Make disclaimer work RTL#35164
mszylkowski merged 20 commits into
ampproject:mainfrom
mszylkowski:interactive_toggledisclaimer

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Jul 9, 2021

Changes:

  • Add RTL support for component.
  • Align left the dialog to the interactive component (or right if RTL)
Before opening After opening
Before opening RTL After opening RTL

Narrow components will still constrain the dialog to the width of the component.
image

@mszylkowski mszylkowski self-assigned this Jul 9, 2021
@mszylkowski mszylkowski changed the title ✨ [Story interactive] Add Google backend to docs and activate disclaimer ✨ [Story interactive] Make disclaimer work RTL Jul 19, 2021
@mszylkowski mszylkowski marked this pull request as ready for review July 19, 2021 15:19
@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-abstract.js
extensions/amp-story-interactive/0.1/amp-story-interactive-disclaimer.css

@mszylkowski mszylkowski enabled auto-merge (squash) July 19, 2021 15:41
@mszylkowski mszylkowski merged commit 1459825 into ampproject:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants