Skip to content

Commit 44e94fe

Browse files
authored
Apply suggestions from code review
Fix blocking issue
1 parent adea69d commit 44e94fe

3 files changed

Lines changed: 34 additions & 34 deletions

File tree

docs/tools/visual-studio-code/create-azure-function-with-mssql-command-palette.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,59 +20,59 @@ Microsoft SQL Bindings for VS Code enable users to develop Azure Functions with
2020
## From the Command Palette
2121
Run the `MS SQL: Create Azure Function with SQL Binding` command from the command palette to create a new function with a SQL binding.
2222

23-
:::image type="content" alt-text="Screenshot of a VS Code command palette command `MS SQL: Create Azure Function with SQL Binding (preview)" source="./media/create-azure-function-with-mssql/create-azure-function-using-command-palette.png":::
23+
:::image type="content" alt-text="Screenshot of a VS Code command palette command `MS SQL: Create Azure Function with SQL Binding (preview)." source="./media/create-azure-function-with-mssql/create-azure-function-using-command-palette.png":::
2424

2525
The extension will then prompt you to select the object type to insert (`Input binding`) or upsert into (`Output binding`), either a `Table` or `View`.
2626

27-
:::image type="content" alt-text="Screenshot of a prompt to select the object type" source="./media/create-azure-function-with-mssql/select-object-type.png":::
27+
:::image type="content" alt-text="Screenshot of a prompt to select the object type." source="./media/create-azure-function-with-mssql/select-object-type.png":::
2828

2929
Then the extension will prompt you to select a connection profile to use for the Azure Function or create a connection profile.
3030

31-
:::image type="content" alt-text="Screenshot of a prompt for connection profile" source="./media/create-azure-function-with-mssql/prompt-for-connection-profile.png":::
31+
:::image type="content" alt-text="Screenshot of a prompt for connection profile." source="./media/create-azure-function-with-mssql/prompt-for-connection-profile.png":::
3232

3333
Once you either select a connection profile or create a new connection profile, the extension will prompt you to select the database from the selected connection to use for the Azure Function.
3434

35-
:::image type="content" alt-text="Screenshot of a prompt for database" source="./media/create-azure-function-with-mssql/select-database.png":::
35+
:::image type="content" alt-text="Screenshot of a prompt for database" source.="./media/create-azure-function-with-mssql/select-database.png":::
3636

3737
Once you select a database, the extension will prompt you to select a table, or view to use or to enter a table or view to query or upsert into. This prompt is based on the object type you selected earlier.
3838

3939
> [!NOTE]
4040
> Azure Function with SQL Binding from a `View` is only supported for `Input` bindings.
4141
4242
Prompt for Table:
43-
:::image type="content" alt-text="Screenshot of a prompt for table" source="./media/create-azure-function-with-mssql/select-table.png":::
43+
:::image type="content" alt-text="Screenshot of a prompt for table." source="./media/create-azure-function-with-mssql/select-table.png":::
4444

4545
Prompt for View:
46-
:::image type="content" alt-text="Screenshot of a prompt for view" source="./media/create-azure-function-with-mssql/select-view.png":::
46+
:::image type="content" alt-text="Screenshot of a prompt for view." source="./media/create-azure-function-with-mssql/select-view.png":::
4747

4848
The extension will then prompt you to enter the function name to be used for the Azure Function.
4949

50-
:::image type="content" alt-text="Screenshot of a prompt to enter function name" source="./media/create-azure-function-with-mssql/function-name-prompt.png":::
50+
:::image type="content" alt-text="Screenshot of a prompt to enter function name." source="./media/create-azure-function-with-mssql/function-name-prompt.png":::
5151

5252
If you already have connection strings stored in the local.settings.json, then the extension will prompt you to select the connection string to use for the Azure Function or create a new connection string.
5353

54-
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting" source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
54+
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting." source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
5555

5656
If you select `Create new local app setting`, then the extension will prompt you to enter the connection string name and value.
5757

58-
:::image type="content" alt-text="Screenshot of a prompt to enter connection string" source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
58+
:::image type="content" alt-text="Screenshot of a prompt to enter connection string." source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
5959

6060
If you're creating the `Azure Function with SQL Binding` to an existing Azure Function project, then the extension will prompt you whether you would like to include the password for the connection string in the local.settings.json file.
6161

62-
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string" source="./media/create-azure-function-with-mssql/password-prompt.png":::
62+
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string." source="./media/create-azure-function-with-mssql/password-prompt.png":::
6363

6464
If `Yes`, then the password will be saved to the local.settings.json file. If `No` then the extension will warn you that the password won't be saved to the local.settings.json file (shown below), and you'll need to manually add the password later to the local.settings.json file.
6565

66-
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually" source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
66+
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually." source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
6767

6868
The extension will then prompt you to provide the namespace for the Azure Function.
69-
:::image type="content" alt-text="Screenshot of a prompt for namespace for the Azure Function" source="./media/create-azure-function-with-mssql/namespace-for-function.png":::
69+
:::image type="content" alt-text="Screenshot of a prompt for namespace for the Azure Function." source="./media/create-azure-function-with-mssql/namespace-for-function.png":::
7070

7171
If you're creating a brand new Azure Function project with SQL binding, then the extension will prompt whether you would like to include the password for the connection string in the local.settings.json file.
7272

7373
A progress notification will appear to indicate that the Azure Function has completed.
7474

75-
:::image type="content" alt-text="Screenshot of a information message indicating finished creating Azure Function Project" source="./media/create-azure-function-with-mssql/finished-creating-project.png":::
75+
:::image type="content" alt-text="Screenshot of a information message indicating finished creating Azure Function Project." source="./media/create-azure-function-with-mssql/finished-creating-project.png":::
7676

7777
Once the Azure Function is created, the extension will generate the code either for an `Input` or `Output` binding shown [here](create-azure-function-with-mssql.md#generated-code-for-azure-functions-with-sql-bindings).
7878

@@ -81,41 +81,41 @@ Once the Azure Function is created, the extension will generate the code either
8181
#### In an existing Azure Function
8282
Open the C# Azure Function in an editor and then run the `MS SQL: Add SQL Binding` command from the command palette to add a SQL binding to an existing function.
8383

84-
:::image type="content" alt-text="Screenshot of a VS Code command palette command `MS SQL: Add SQL Binding (preview)" source="./media/create-azure-function-with-mssql/add-sql-binding-command-palette.png":::
84+
:::image type="content" alt-text="Screenshot of a VS Code command palette command `MS SQL: Add SQL Binding (preview)." source="./media/create-azure-function-with-mssql/add-sql-binding-command-palette.png":::
8585

8686
The extension will then prompt you to select Azure function in the current file to add the SQL binding to.
87-
:::image type="content" alt-text="Screenshot of Azure Functions found in project" source="./media/create-azure-function-with-mssql/select-azure-functions-in-file.png":::
87+
:::image type="content" alt-text="Screenshot of Azure Functions found in project." source="./media/create-azure-function-with-mssql/select-azure-functions-in-file.png":::
8888

8989
If you're creating an Azure Function with SQL binding from a table, the extension will prompt you to select the binding type to use, either an `Input` (Retrieves data from a database) or `Output` (Save data to a database) binding.
9090

9191
If you already have connection strings stored in the local.settings.json, then the extension will prompt you to select the connection string to use for the Azure Function or create a new connection string.
9292

93-
:::image type="content" alt-text="Screenshot of a prompt to select or create a new connection string setting" source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
93+
:::image type="content" alt-text="Screenshot of a prompt to select or create a new connection string setting." source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
9494

9595
If you select `Create new local app setting`, then the extension will prompt you to enter the connection string name and value.
9696

97-
:::image type="content" alt-text="Screenshot of a prompt to enter connection string" source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
97+
:::image type="content" alt-text="Screenshot of a prompt to enter connection string." source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
9898

9999
The extension will then prompt you to select a connection string method to select a connection profile or enter a connection string to use for the SQL binding.
100100

101-
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting method" source="./media/create-azure-function-with-mssql/select-connection-string-method.png":::
101+
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting method." source="./media/create-azure-function-with-mssql/select-connection-string-method.png":::
102102

103103
If you decide to select a connection profile, the extension will prompt you to select the database from the selected connection to use for the Azure Function.
104104

105-
:::image type="content" alt-text="Screenshot of a prompt for database" source="./media/create-azure-function-with-mssql/select-database.png":::
105+
:::image type="content" alt-text="Screenshot of a prompt for database." source="./media/create-azure-function-with-mssql/select-database.png":::
106106

107107
Once you select a database, the extension will prompt you to select a table to use, or to enter a table or view to query or upsert into.
108108

109109
Prompt for Table:
110-
:::image type="content" alt-text="Screenshot of a prompt for table" source="./media/create-azure-function-with-mssql/select-table.png":::
110+
:::image type="content" alt-text="Screenshot of a prompt for table." source="./media/create-azure-function-with-mssql/select-table.png":::
111111

112112
The extension will then prompt you whether you would like to include the password for the connection string in the local.settings.json file.
113113

114-
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string" source="./media/create-azure-function-with-mssql/password-prompt.png":::
114+
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string." source="./media/create-azure-function-with-mssql/password-prompt.png":::
115115

116116
If `Yes`, then the password will be saved to the local.settings.json file. If `No` then the extension will warn you that the password won't be saved to the local.settings.json file (shown below), and you'll need to manually add the password later to the local.settings.json file.
117117

118-
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually" source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
118+
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually." source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
119119

120120
Once the Azure Function is created, the extension will generate the code either for an `Input` or `Output` binding shown [here](create-azure-function-with-mssql.md#generated-code-for-azure-functions-with-sql-bindings).
121121

docs/tools/visual-studio-code/create-azure-function-with-mssql-object-explorer.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,48 +28,48 @@ To create an Azure Function from a specific `Table` or `View` in object explorer
2828

2929
If you haven't yet created the Azure Function project, a VS Code prompt will appear to aid in creating a new Azure Function project.
3030

31-
:::image type="content" alt-text="Screenshot of VS Code notification to create a new Azure Function project since none were found in folder" source="./media/create-azure-function-with-mssql/create-azure-function-project.png":::
31+
:::image type="content" alt-text="Screenshot of VS Code notification to create a new Azure Function project since none were found in folder." source="./media/create-azure-function-with-mssql/create-azure-function-project.png":::
3232

3333
The extension will then ask you to select the folder where you want to create the Azure Function.
3434

35-
:::image type="content" alt-text="Screenshot of a prompt to choose folder to create Azure Function with SQL binding to" source="./media/create-azure-function-with-mssql/select-folder-to-use-for-function.png":::
35+
:::image type="content" alt-text="Screenshot of a prompt to choose folder to create Azure Function with SQL binding to." source="./media/create-azure-function-with-mssql/select-folder-to-use-for-function.png":::
3636

3737
If you're creating an Azure Function with SQL binding from a table, the extension will prompt you to select the binding type to use, either an `Input` (Retrieves data from a database) or `Output` (Save data to a database) binding.
3838

3939
> [!NOTE]
4040
> Azure Function with SQL Binding from a `View` is only supported for `Input` bindings.
4141
42-
:::image type="content" alt-text="Screenshot of a prompt to select binding type" source="./media/create-azure-function-with-mssql/binding-type-prompt.png":::
42+
:::image type="content" alt-text="Screenshot of a prompt to select binding type." source="./media/create-azure-function-with-mssql/binding-type-prompt.png":::
4343

4444
The extension will then prompt you to enter the function name to be used for the Azure Function.
4545

46-
:::image type="content" alt-text="Screenshot of a prompt to enter function name" source="./media/create-azure-function-with-mssql/function-name-prompt.png":::
46+
:::image type="content" alt-text="Screenshot of a prompt to enter function name." source="./media/create-azure-function-with-mssql/function-name-prompt.png":::
4747

4848
If you already have connection strings stored in the local.settings.json, then the extension will prompt you to select the connection string to use for the Azure Function or create a new connection string.
4949

50-
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting" source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
50+
:::image type="content" alt-text="Screenshot of a prompt to select connection string setting." source="./media/create-azure-function-with-mssql/create-new-sql-connection-string-setting.png":::
5151

5252
If you select `Create new local app setting`, then the extension will prompt you to enter the connection string name and value.
5353

54-
:::image type="content" alt-text="Screenshot of a pPrompt to enter connection string" source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
54+
:::image type="content" alt-text="Screenshot of a pPrompt to enter connection string." source="./media/create-azure-function-with-mssql/enter-connection-string-setting-name.png":::
5555

5656
If you're creating the `Azure Function with SQL Binding` to an existing Azure Function project, then the extension will prompt you whether you would like to include the password for the connection string in the local.settings.json file.
5757

58-
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string" source="./media/create-azure-function-with-mssql/password-prompt.png":::
58+
:::image type="content" alt-text="Screenshot of a prompt to save the password to the SQL connection string." source="./media/create-azure-function-with-mssql/password-prompt.png":::
5959

6060
If `Yes`, then the password will be saved to the local.settings.json file. If `No` then the extension will warn you that the password won't be saved to the local.settings.json file (shown below), and you'll need to manually add the password later to the local.settings.json file.
6161

62-
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually" source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
62+
:::image type="content" alt-text="Screenshot of a warning to add password to SQL connection string later manually." source="./media/create-azure-function-with-mssql/do-not-save-password.png":::
6363

6464
The extension will then prompt you to provide the namespace for the Azure Function.
6565

66-
:::image type="content" alt-text="Screenshot of a prompt for namespace for the Azure Function" source="./media/create-azure-function-with-mssql/namespace-for-function.png":::
66+
:::image type="content" alt-text="Screenshot of a prompt for namespace for the Azure Function." source="./media/create-azure-function-with-mssql/namespace-for-function.png":::
6767

6868
If you're creating a brand new Azure Function project with SQL binding, then the extension will prompt whether you would like to include the password for the connection string in the local.settings.json file.
6969

7070
A progress notification will appear to indicate that the Azure Function has completed.
7171

72-
:::image type="content" alt-text="Screenshot of a information message indicating finished creating Azure Function Project" source="./media/create-azure-function-with-mssql/finished-creating-project.png":::
72+
:::image type="content" alt-text="Screenshot of a information message indicating finished creating Azure Function Project." source="./media/create-azure-function-with-mssql/finished-creating-project.png":::
7373

7474
Once the Azure Function is created, the extension will generate the code either for an `Input` or `Output` binding shown [here](create-azure-function-with-mssql.md#generated-code-for-azure-functions-with-sql-bindings).
7575

docs/tools/visual-studio-code/create-azure-function-with-mssql.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ See further documentation to create an Azure function with SQL bindings from the
3333
## From the Command Palette
3434
Run the `MS SQL: Create Azure Function with SQL Binding` command from the command palette to create a new function with a SQL binding.
3535

36-
:::image type="content" alt-text="VS Code command palette command `MS SQL: Create Azure Function with SQL Binding (preview)" source="./media/create-azure-function-with-mssql/create-azure-function-using-command-palette.png":::
36+
:::image type="content" alt-text="VS Code command palette command `MS SQL: Create Azure Function with SQL Binding (preview)." source="./media/create-azure-function-with-mssql/create-azure-function-using-command-palette.png":::
3737

3838
See further documentation to create an Azure function with SQL bindings from the command palette [here](create-azure-function-with-mssql-command-palette.md).
3939

4040
### In an existing Azure Function
4141

4242
Open the C# Azure Function in an editor and then run the `MS SQL: Add SQL Binding` command from the command palette to add a SQL binding to an existing function.
4343

44-
:::image type="content" alt-text="VS Code command palette command `MS SQL: Add SQL Binding (preview)" source="./media/create-azure-function-with-mssql/add-sql-binding-command-palette.png":::
44+
:::image type="content" alt-text="VS Code command palette command `MS SQL: Add SQL Binding (preview)." source="./media/create-azure-function-with-mssql/add-sql-binding-command-palette.png":::
4545

4646
See further documentation [here](create-azure-function-with-mssql-command-palette.md).
4747

0 commit comments

Comments
 (0)