Use helpers instead of request objects

Author: sethvargo

kms/api/Kms.Samples.Tests/CreateKeyAsymmetricDecryptTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal(CryptoKey.Types.CryptoKeyPurpose.AsymmetricDecrypt, key.Purpose);
         Assert.Equal(CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm.RsaDecryptOaep2048Sha256, key.VersionTemplate.Algorithm);

kms/api/Kms.Samples.Tests/CreateKeyAsymmetricSignTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal(CryptoKey.Types.CryptoKeyPurpose.AsymmetricSign, key.Purpose);
         Assert.Equal(CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm.RsaSignPkcs12048Sha256, key.VersionTemplate.Algorithm);

kms/api/Kms.Samples.Tests/CreateKeyHsmTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal(ProtectionLevel.Hsm, key.VersionTemplate.ProtectionLevel);
     }

kms/api/Kms.Samples.Tests/CreateKeyLabelsTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal("alpha", key.Labels["team"]);
         Assert.Equal("cc1234", key.Labels["cost_center"]);

kms/api/Kms.Samples.Tests/CreateKeyRingTests.cs

@@ -47,10 +47,7 @@ public void CreatesKeyRing()
 
         // Get the key ring.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var keyRing = client.GetKeyRing(new GetKeyRingRequest
-        {
-            KeyRingName = result.KeyRingName,
-        });
+        var keyRing = client.GetKeyRing(result.KeyRingName);
 
         Assert.Contains(_keyRingId, keyRing.Name);
     }

kms/api/Kms.Samples.Tests/CreateKeyRotationScheduleTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal(2_592_000, key.RotationPeriod.Seconds);
         Assert.NotNull(key.NextRotationTime);

kms/api/Kms.Samples.Tests/CreateKeySymmetricEncryptDecryptTests.cs

@@ -39,10 +39,7 @@ public void CreatesKey()
 
         // Get the key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var key = client.GetCryptoKey(new GetCryptoKeyRequest
-        {
-            CryptoKeyName = result.CryptoKeyName,
-        });
+        var key = client.GetCryptoKey(result.CryptoKeyName);
 
         Assert.Equal(CryptoKey.Types.CryptoKeyPurpose.EncryptDecrypt, key.Purpose);
         Assert.Equal(CryptoKeyVersion.Types.CryptoKeyVersionAlgorithm.GoogleSymmetricEncryption, key.VersionTemplate.Algorithm);

kms/api/Kms.Samples.Tests/CreateKeyVersionTests.cs

@@ -38,10 +38,7 @@ public void CreatesKeyVersion()
 
         // Get the key version.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var response = client.GetCryptoKeyVersion(new GetCryptoKeyVersionRequest
-        {
-            CryptoKeyVersionName = result.CryptoKeyVersionName,
-        });
+        var response = client.GetCryptoKeyVersion(result.CryptoKeyVersionName);
 
         Assert.NotNull(response.CryptoKeyVersionName.CryptoKeyVersionId);
     }

kms/api/Kms.Samples.Tests/DecryptAsymmetricTests.cs

@@ -39,10 +39,8 @@ public void DecryptsDataa()
 
         // Get the public key.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var publicKey = client.GetPublicKey(new GetPublicKeyRequest
-        {
-            CryptoKeyVersionName = new CryptoKeyVersionName(_fixture.ProjectId, _fixture.LocationId, _fixture.KeyRingId, _fixture.AsymmetricDecryptKeyId, "1"),
-        });
+        CryptoKeyVersionName keyVersionName = new CryptoKeyVersionName(_fixture.ProjectId, _fixture.LocationId, _fixture.KeyRingId, _fixture.AsymmetricDecryptKeyId, "1");
+        var publicKey = client.GetPublicKey(keyVersionName);
 
         // Split the key into blocks and base64-decode the PEM parts.
         var blocks = publicKey.Pem.Split("-", StringSplitOptions.RemoveEmptyEntries);

kms/api/Kms.Samples.Tests/DecryptSymmetricTests.cs

@@ -37,11 +37,8 @@ public void DecryptsData()
 
         // Create some ciphertext.
         KeyManagementServiceClient client = KeyManagementServiceClient.Create();
-        var result = client.Encrypt(new EncryptRequest
-        {
-            ResourceName = new CryptoKeyName(_fixture.ProjectId, _fixture.LocationId, _fixture.KeyRingId, _fixture.SymmetricKeyId),
-            Plaintext = ByteString.CopyFromUtf8(plaintext),
-        });
+        CryptoKeyName keyName = new CryptoKeyName(_fixture.ProjectId, _fixture.LocationId, _fixture.KeyRingId, _fixture.SymmetricKeyId);
+        var result = client.Encrypt(keyName, ByteString.CopyFromUtf8(plaintext));
 
         // Run the sample code.
         var response = _sample.DecryptSymmetric(